[metadata prespecialization] Search for canonical records in getGenericMetadata. #33465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
Contributor
|
Build failed |
Contributor
|
Build failed |
nate-chandler
force-pushed
the
generic-metadata-prespecialization-components/return-canonical-prespecializations-from-getGenericMetadata
branch
from
1f2d4bc to
aa41a12
Compare
Contributor
Author
|
@swift-ci please test |
1 similar comment
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test windows |
Contributor
|
Build failed |
nate-chandler
force-pushed
the
generic-metadata-prespecialization-components/return-canonical-prespecializations-from-getGenericMetadata
branch
from
ce9c09c to
e021a36
Compare
Contributor
Author
|
@swift-ci please test and merge |
1 similar comment
Contributor
Author
|
@swift-ci please test and merge |
Previously, the metadata accessor for which canonical prespecializations had been formed included checks against the passed-in arguments to determine whether the access matched a prespecialized record or not. Now that the prespecialized records are attached to the nominal type descriptor for the type, eliminate this hard-coded generated code and instead let swift_getGenericMetadata do the work of looking through the prespecializations.
nate-chandler
force-pushed
the
generic-metadata-prespecialization-components/return-canonical-prespecializations-from-getGenericMetadata
branch
from
e021a36 to
409bc9d
Compare
Contributor
Author
|
@swift-ci please test and merge |
1 similar comment
Contributor
Author
|
@swift-ci please test and merge |
nate-chandler
deleted the
generic-metadata-prespecialization-components/return-canonical-prespecializations-from-getGenericMetadata
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the metadata accessor for which canonical prespecializations had been formed included checks against the passed-in arguments to determine whether the access matched a prespecialized record or not.
Now that the prespecialized records are attached to the nominal type descriptor for the type, eliminate this hard-coded generated code and instead let swift_getGenericMetadata do the work of looking through the prespecializations.
Depends on #33442 .